Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CV32A60X as first release #916

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Conversation

MikeOpenHWGroup
Copy link
Member

As discuss on MatterMost, here is proposed change to the requirements spec to introduce the initial configuration of the CVA6.

@JeanRochCoulon
Copy link
Contributor

Hi Mike, it looks fine to me ! Could you just replace sv39 by sv32 for MMU, when we are in 32bits, sv is lower than 32

@MikeOpenHWGroup
Copy link
Member Author

Hi Mike, it looks fine to me ! Could you just replace sv39 by sv32 for MMU, when we are in 32bits, sv is lower than 32

Done. Thanks for the catch.

Copy link
Contributor

@jquevremont jquevremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way to present configurations is excellent.
Pedantic: CVFPU is not defined. I suggest to either define it at the end of the document or revert to FPU. (not a blocking comment)

@MikeOpenHWGroup
Copy link
Member Author

Pedantic: CVFPU is not defined. I suggest to either define it at the end of the document or revert to FPU. (not a blocking comment)

Good point. I have replaced all instances of "CVFPU" with "FPU".

Copy link
Contributor

@jquevremont jquevremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanRochCoulon JeanRochCoulon merged commit 767c465 into master Jun 28, 2022
@JeanRochCoulon JeanRochCoulon deleted the introduce_cv32a60x branch June 28, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants