Upgrade to Blockly v11 and respective plugin versions#3398
Upgrade to Blockly v11 and respective plugin versions#3398florian-h05 merged 5 commits intoopenhab:mainfrom
Conversation
#3962 Bundle Size — 12.53MiB (+1.78%).50c9999(current) vs 47adde1 main#3958(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Warning Bundle introduced 4 new packages: @mit-app-inventor/blockly-plugin-workspace-multiselect, dragselect, @blockly/field-colour and one more – View changed packages Bundle metrics
Bundle size by type
Bundle analysis report Branch jsjames:blockly-v11 Project dashboard Generated by RelativeCI Documentation Report issue |
7121969 to
7a065eb
Compare
|
As testing Blockly is always a larger effort for @stefan-hoehn, I wonder whether we shouldn't try to upgrade to Blockly 12 now, so we don't need to test twice. WDYT @jsjames? |
I did try, but the plugin @mit-app-inventor/blockly-plugin-workspace-multiselect does not yet support it . Since there is an issue with our vue3 version where multi-select does not currently work (I recall it being a runtime issue in the @mit-app-inventor/blockly-plugin-workspace-multiselect ), this was the most expedient way to address. The question is how critical is it to get the multi-select feature working? |
|
That’s quite unfortunate. |
v11 does get rid of the remaining deprecated packages warnings in package.json! |
'@mit-app-inventor/blockly-plugin-workspace-multiselect' working. Required updating of imports and making sure 'workspace' was not reactive (https://groups.google.com/g/blockly/c/myo3FXL3r_Y/m/NLgPZNc0CgAJVue3). added support for blockly comments (add comment via context menu) Signed-off-by: Jeff James <jeff@james-online.com> Signed-off-by: Florian Hotze <dev@florianhotze.com>
7a065eb to
5efb53d
Compare
Signed-off-by: Florian Hotze <dev@florianhotze.com>
There was a problem hiding this comment.
I have now compared the code generation between this PR and 1ac744b for all tests from https://github.com/openhab/openhab-webui/tree/main/bundles/org.openhab.ui/web/test/blockly.
The generated code is identical, except for:
- blockly_datetime_creation_comparison due to #3361
- persistence code generation fails with:
ReferenceError: Input "dayInfoUntil" doesn't exist on "oh_get_persistvalue"
This seems to be a direct consequence of:
Calling statementToCode or valueToCode on inputs that don't exist will now throw an error instead of returning an empty string.
from https://groups.google.com/g/blockly/c/Ai8C0tEiPbI?pli=1
I am working on a solution right now.
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
It seems when first dealing with this issue in openhab#3398 some occurences were missed, this should fix all of them. Signed-off-by: Florian Hotze <dev@florianhotze.com>
It seems when first dealing with this issue in #3398 some occurences were missed, this should fix all of them. Signed-off-by: Florian Hotze <dev@florianhotze.com>
Moved to v11 to address issues with '@mit-app-inventor/blockly-plugin-workspace-multiselect' in port to vue3.