Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.54.0 #6385

Merged
merged 4 commits into from
May 25, 2023
Merged

build: release v6.54.0 #6385

merged 4 commits into from
May 25, 2023

Conversation

LinHuiqing
Copy link
Contributor

@LinHuiqing LinHuiqing commented May 25, 2023

New

Dependencies

Dev-Dependencies

Tests

feat: add response time to submission #6377

@justynoh

To ensure functionality

  • 1. Go to a public storage mode form with logic, fill in the form and submit
  • 2. The submission should have been logged with the response time and number of visible fields (and the submission document in DB should reflect it too)
  • 3. Repeat the steps for email mode form

(For env with REACT_MIGRATION_USE_FETCH_FOR_SUBMISSIONS set to true)

  • 4. Repeat the steps 1 and 2 above for storage mode form with fetch for submission
  • 5. Repeat the steps 1 and 2 above for email mode form with fetch for submission

For payment forms

  • 6. Go to a payment form, fill in the form and submit
  • 7. The pending submission should have been logged with the response time and number of visible fields (and the pending submission document in DB should reflect it too)
  • 8. Complete the payment
  • 9. The completed submission document for the payment should still contain the response metadata

To check for regression

  • Submit a storage mode form without logic
  • Submit an email mode form without logic
  • Submit a preview mode, storage mode form with logic
  • Submit a preview mode, email mode form with logic
  • Create a use-template form with logic

Testing without responseMetadata

  • Try and call the email submission api endpoint without a responseMetadata in the body (can use an empty form), the submission should still be successful
  • Try and call the encrypt submission api endpoint without a responseMetadata in the body (can use an empty form), the submission should still be successful

feat: update payment settings copy for production launch #6381

@wanlingt

Check that the payment settings page has the right copy under the following conditions:

  • Production env (set SECRET_ENV=production)
    • Before Stripe account is connected (design)
    • After Stripe account is connected (design)
  • Non-production env (set SECRET_ENV=staging or development or test)
    • Before Stripe account is connected (design)
    • After Stripe account is connected (design)
    • After Stripe account connection is skipped (design)

LinHuiqing and others added 4 commits May 24, 2023 16:08
build: merge v6.53.0 into develop
* feat: update payment settings copy before connection

* fix: stripe connect button not shown after connection

* feat: stripe acc connected copy changes based on env

* refactor: cleaner payment settings section

* docs: add comment for checkbox and connect button
* feat: add context for visibleFields and submissionTime

* feat: update number of visible fields in context

* feat: add ResponseMetadata to submission type

* feat: add responseMetadata to submission schema

* feat: shifted init of startTime to PublicFormPage

* feat: add optional responseMetadata to encrypt submission route

* feat: add responseMetadata as body to PublicFormService

* feat: add responseMetaData to email mode submissions

* chore: remove logging

* refactor: change ResponseMeta type to use zod

* chore: update typing of email req body

* chore: set ResponseMetadata as optional in type

* chore: update req body type of email submission

* fix: make FE responseMetadata optional to allow for preview form submission

* fix: ensure that only public forms updates visible field number

Not preview nor template mode

* chore: remove unneeded response metadata in submissiondto

* test: update test for submission model and email submission service

* test: add tests for encrypt submissions

* chore: add comments for setter conditional
@LinHuiqing LinHuiqing temporarily deployed to staging-al2 May 25, 2023 07:09 — with GitHub Actions Inactive
@LinHuiqing LinHuiqing merged commit 13af75b into release-al2 May 25, 2023
@LinHuiqing LinHuiqing deleted the release_v6.54.0 branch May 25, 2023 08:28
@timotheeg timotheeg mentioned this pull request May 26, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants