Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support #513

Closed
cmbirk opened this issue Mar 18, 2015 · 11 comments
Closed

i18n support #513

cmbirk opened this issue Mar 18, 2015 · 11 comments

Comments

@cmbirk
Copy link
Contributor

cmbirk commented Mar 18, 2015

It looks like we have 2 good options for i18n, angular-translate and angular-gettext.

There's a debate between the two creators on this GH issue:

rubenv/angular-gettext#3

and a decent post on the subject here

http://blog.trifork.com/2014/04/10/internationalization-with-angularjs/

@eduard-k and @savajr does this approach work for you guys as well?

@Vanuan
Copy link
Contributor

Vanuan commented Mar 19, 2015

As I see Madison is not a single page application, so I don't see advantage over Lavarel i8n

@cmbirk
Copy link
Contributor Author

cmbirk commented Mar 19, 2015

The 1.8 milestone includes a single page application structure for Madison.

@cmbirk cmbirk assigned cmbirk and unassigned krusynth May 11, 2015
@cmbirk
Copy link
Contributor Author

cmbirk commented May 18, 2015

Moving this to 2.0 milestone

@cmbirk cmbirk modified the milestones: 2.0, 1.8 May 18, 2015
@Vanuan
Copy link
Contributor

Vanuan commented Aug 2, 2015

Another option is built-in angular 1.4 support: https://github.com/angular/i18n

@barryvdh
Copy link
Contributor

So, is there any update on this?

@krusynth
Copy link
Contributor

Actually, yes! I got most of this figured out over on the editor in opengovfoundation/madison-editor@9f2f080 and I'm implementing this in Madison today.

@krusynth
Copy link
Contributor

krusynth commented Nov 13, 2015

Ok, I've made a big dent in this. You should be able to create your own locale files and add them in the public/locales folder, matching the format of the en_US.json one I've created.

There are a few outstanding pieces of this that I haven't had time to deal with, and I could certainly use some help on these.

Remaining Work

There are, of course, probably other issues I haven't thought of or encountered yet as well. I also need to write up documentation on the translations, but we're using Angular Translate for this if that helps.

@krusynth
Copy link
Contributor

This is all in the i18n branch at the moment, but will get merged into master very soon.

@krusynth
Copy link
Contributor

This is now in master, but this issue will remain open until those five items are resolved. Also - if you do create a new locale file please contribute it back via a Pull Request to the main repo! We really could use a lot of help on this front!

@krusynth
Copy link
Contributor

Updated this with new items.

@sethetter
Copy link
Collaborator

In v4, site is fully i18n'd, just lacking translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants