Repository navigation
cleanup(tools): delete finished tools/rdna2_028 campaign drivers - #87
Draft
BlivionIaG wants to merge 1 commit into
Draft
BlivionIaG wants to merge 1 commit into
BlivionIaG wants to merge 1 commit into
Conversation
The one-off campaign, probe, and matrix drivers under tools/rdna2_028 are finished and unreferenced by the live TunableOp row pipeline. Drop two doc how-to lines that only named deleted scripts. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Signed-off-by: Cursor Agent <cursoragent@cursor.com>
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Delete the finished one-off experiment drivers under
tools/rdna2_028/. The live TunableOp row pipeline stays. This is subtraction only: 44 files removed, and two doc lines that were only how-to commands for deleted scripts. No edits undervllm/,csrc/,tools/rdna/,tools/rdna2/, recipes,AGENTS.md, orbench_results/.This PR supersedes the
tools/rdna2_028deletions in draft #42. #42 targets the stale baserdna_extra/v0.28.0and cannot land onrdna_extras. #42 itself was not modified. No other open PR deletes these drivers onrdna_extras.AI assistance was used (Cursor Grok 4.7). No model-output, accuracy, or serving change, so no model eval. Every listed file was dead; none was kept as still live.
Kept (live row pipeline)
docs/rdna2/tuning.mdnames these, andtools/rdna/serve_rdna.shplustools/rdna/rdna_launcher_common.shsourcetunableop_env.sh:tools/rdna2_028/tunableop_env.shtools/rdna2_028/tunableop_rows_pipeline.sh(calls onlytune_prod_shapes.py)tools/rdna2_028/tune_prod_shapes.pytools/rdna2_028/curate_tunableop_rows.pytools/rdna2_028/verify_tunableop_lookup.pytools/rdna2_028/verify_lookup_hit.sh(calls onlyverify_tunableop_lookup.py)tools/rdna2_028/probe_record_untuned.pyDeleted
Repo-wide search before deletion (
vllm/,csrc/,tools/,tests/,benchmarks/,CMakeLists.txt,.github/,tools/rdna/recipes) found no live source, import, or exec. The seven kept files do not call any of them. Callers that did exist were other files in this delete set. After deletion, a repeat of that search is empty.campaign_3a_capture.sh,campaign_3bcd_arm.sh,campaign_3bcd_curate.sh,campaign_3d_freeze.sh,campaign_matrix.shbench_results/2026-09-30_campaign-matrix/SUMMARY.md,bench_results/2026-10-01_exl3-tunableop/repo-rows-premerge/provenance.jsonpr30_b1_probe.sh,pr30_b2_rocprof.sh,pr30_b3_driver.shaudit_w4a16.sh,audit_split/(audit_split_swap.py,split_old.txt,split_fixed.txt)step0_parse.py,step0_profile.sh,step0_torchprof.sh,step0_tp_parse.pybench_results/2026-10-02_sweep-gaps/SUMMARY.mdexl3_capture.sh,exl3_validate.sh,exl3_mtp2_validate.sh,exl3_analyze.py,exl3_freezer.py,exl3_tunableop_campaign.shbench_results/2026-10-01_exl3-tunableop/SUMMARY.md,bench_results/2026-10-01_exl3-27b-mtp2/SUMMARY.md,tunableop/rocm7.14-rocblas5.5/provenance.jsonflashnext_w4a8_arm.sh,flashnext_w4a8_extract.py,flashnext_w4a8_matrix.shbench_results/2026-09-29_w4a16-regression-audit/SUMMARY.md,bench_results/2026-09-29_tunableop-rows/SUMMARY.mdfp32_accum_matrix.sh,fp_aroff_27b.sh,m27b_matrix.sh,w4a8_ab.sh,wt_ab.shbench_results/2026-09-29_tp4-fp-aroff/SUMMARY.md,bench_results/2026-09-29_w4a16-regression-audit/SUMMARY.md,bench_results/2026-09-30_fp32-accum-matrix/SUMMARY.md,bench_results/2026-10-02_sweep-gaps/SUMMARY.mdprobe_force_split.py,probe_gptq_k.py,probe_inmodel_layer.py,probe_model_inspect2.py,probe_mtp_sampling.py,probe_prefill_split.py,probe_real_weights.py,probe_w4a8.py,probe_w4a8_moe.py,probe_w4a8_op.pydocs/rdna2/w4a8-moe-wiring.md(see follow-ups)parse_kernel_sass.py,build_rocm_c_incr.sh,analyze_captures.py,tunableop_rows_e2e.shbench_results/2026-09-29_w4a8-splitk-fix/SUMMARY.md,bench_results/2026-09-30_campaign-matrix/SUMMARY.md, comment inbench_results/2026-10-02_pr34-fa-prefill-d128/remote/build_arm.shDoc how-to lines dropped, and nothing else in those docs:
docs/explore/w4a16-compile-dispatch/RESULTS-2026-09-30.md: the Flash-Next bullet that only namedflashnext_w4a8_arm.sh.docs/rdna2/w4a8-wiring.md: the sentence that only namedm27b_matrix.shas the matrix driver.Follow-ups (not done here)
docs/rdna2/w4a8-moe-wiring.mdstill namesprobe_w4a8_moe.pyin the "what changed" table and as the caption of the L2 micro table. Those lines record a past result; they are not a how-to command, so they were left for the docs cleanup.tunableop/rocm7.14-rocblas5.5/provenance.jsonstill records the historicaltune_method/capture_methodstrings that nameexl3_tunableop_campaign.shandexl3_capture.sh. That is shipped-row provenance, not a caller.bench_results/summaries (and the archivedbuild_arm.shcomment) still name deleted drivers. The data was not edited.tools/rdna2_028/. Those edits are out of scope for this PR.Test Plan
No GPU. Proof is reference search plus parse of the kept pipeline, and that the launcher still points at an existing
tunableop_env.sh:Test Result
vllm/,csrc/,tools/,tests/,benchmarks/,CMakeLists.txt,.github/,tools/rdna/recipes): no matches. The seven kept files: no matches.bash -non the three kept shell scripts: exit 0.python3 -m py_compileon the four kept Python files: exit 0. This environment has no.venvand nouv; the check is stdlib syntax only.tools/rdna/serve_rdna.sh:244issource "$source_dir/tools/rdna2_028/tunableop_env.sh", and that file is still in the tree.tools/rdna/rdna_launcher_common.sh:97is the same source line and was not edited.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing