Repository navigation
cleanup(rdna): drop leftover bring-up debug probes - #44
Closed
BlivionIaG wants to merge 1 commit into
Closed
BlivionIaG wants to merge 1 commit into
BlivionIaG wants to merge 1 commit into
Conversation
Remove orphan poolwatch and graph-keepalive modules, plus env-gated /tmp dumps that nothing production calls. Live kernel selectors stay. Co-authored-by: Grok 4.7
This was referenced Oct 7, 2026
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove leftover bring-up
/tmpdebug probes and two orphan utils from the recent Python delta. Nothing production imported those modules, and the deleted gates only logged or dumped when an unregistered env var was set. Live kernel-selection knobs stay. No new machinery, and these knobs are not registered inenvs.py.This does not duplicate an open PR. Open PRs on this repo (#2, #25, #37, #40, #41, #42, and the rest) touch other files. #41/#42 are the HIP/
tools/cleanups and were left alone.AI assistance was used (Cursor Grok 4.7). The diff is deletions (918 lines removed, two lines rewritten so the all-reduce return and the W4A16 fallback
ifstay valid).Deleted whole modules (no Python importers)
vllm/utils/rocm_poolwatch.pyvllm/utils/rocm_graph_keepalive.py(the C++ op may stay unbound from Python)Deleted gated debug blocks
VLLM_LOG_GDN_PTRS,VLLM_GDN_OUT_DEBUG,VLLM_GDN_NAN_DEBUG,VLLM_GDN_STATE_DEBUG/VLLM_GDN_SAVE,VLLM_GDN_DBG. KeptVLLM_GDN_HIP_PREFILLandVLLM_GDN_DECODE_RDNA2.VLLM_MAMBA_COPY_DEBUGand thedebuglocal._DEBUG/VLLM_QSA_RDNA2_DEBUG, the clone+print site, and_qsa_dump_bad_rows. KeptVLLM_RDNA_QSA_HIP.VLLM_PIECE_IN_DEBUG,VLLM_CG_NAN_INPUT_CHECK,VLLM_CG_REPLAY_LOG,VLLM_PIECE_DUMP/VLLM_PIECE_TP. KeptVLLM_CG_SKIP_REPLAY, theif not copiedrunnable fallback, and unconditional capture-time_nan_to_num_tree.VLLM_W4A16_PTR_DEBUG/tmplogs.VLLM_BT_DEBUGinblock_table.pyandworker/utils.py.VLLM_DEBUG_PREFIX_HITandVLLM_NO_PARTIAL_HASH. Prefix-hit behavior is unchanged when those vars are unset (they were never registered).awq_prefillarm:_rdna2_w4a16_select_kernelnever returnedawq_prefill. Removed_awq_prefill_available, that branch, and the else-arm call toops.awq_gemm_rdna2_prefill. GPTQ / exllama fallback remains.VLLM_RDNA2_W4A16_RUNTIME_DISPATCHis untouched.Skipped (in-flight or another PR)
vllm/v1/worker/gpu/model_runner.pyVLLM_BT_DEBUG— in-flight.vllm/v1/attention/backends/rdna_attn.pyVLLM_BT_DEBUG— same function as in-flightVLLM_FA_RDNA2_GQA_DEBUG, immediately above that gate.csrc/rocm/qsa_rdna2.cugetenv("VLLM_QSA_RDNA2_DEBUG")— HIP printf cleanup is other work (cleanup(rocm): trim dead W4A8 explore sweep from production copy #41/cleanup(tools): drop finished-experiment drivers and unread env exports #42). Python no longer reads the var.envs.py,exl3.pyVLLM_EXL3_*,hyperconnection.pyVLLM_HC_NAN_DEBUG,rdna_all_reduce.pyVLLM_RDNA_AR_DEBUG— other PRs / in-flight.docs/profiling/andbench_results/snapshots.benchmarks/kernels/w4a16_compile_dispatch/probe.pystill namesawq_gemm_rdna2_prefillinside a kernel-name regex.Test Plan
rgeach deleted env name and symbol undervllm/**/*.py.ast.parseevery edited module.pytest tests/kernels/quantization/test_rdna2_w4a16_selection.py::test_rdna2_w4a16_inner_dispatch -q(pure dispatcher; AWQ still maps to"prefill").Test Result
rgundervllm/**/*.pyis empty for every deleted name (VLLM_LOG_GDN_PTRS,VLLM_GDN_OUT_DEBUG,VLLM_GDN_NAN_DEBUG,VLLM_GDN_STATE_DEBUG,VLLM_GDN_SAVE,VLLM_GDN_DBG,VLLM_MAMBA_COPY_DEBUG,VLLM_QSA_RDNA2_DEBUG,_qsa_dump_bad_rows,VLLM_PIECE_IN_DEBUG,VLLM_CG_NAN_INPUT_CHECK,VLLM_CG_REPLAY_LOG,VLLM_PIECE_DUMP,VLLM_PIECE_TP,VLLM_W4A16_PTR_DEBUG,_awq_prefill_available,VLLM_DEBUG_PREFIX_HIT,VLLM_NO_PARTIAL_HASH,VLLM_RDNA_POOLWATCH,rocm_poolwatch,rocm_graph_keepalive, and the keepalive helpers). Remaining hits are the skipped sites above plus historical docs/bench snapshots.ast.parsesucceeded on all 10 edited modules. Kept selectors still present:VLLM_GDN_HIP_PREFILL,VLLM_GDN_DECODE_RDNA2,VLLM_RDNA_QSA_HIP,VLLM_CG_SKIP_REPLAY, capture-time_nan_to_num_tree.This sandbox has no
.venv,uv,torch, orpytest, so the CPU dispatcher pytest was not executed. No GPU, and no model eval: the removed gates defaulted off and were not on the serving path. The deletedawq_prefillarm was unreachable because the selector never returned that name.No output/accuracy change is expected. Model eval was not run.