Repository navigation
cleanup(tools): delete finished one-shot experiment scripts - #43
Closed
BlivionIaG wants to merge 1 commit into
Closed
BlivionIaG wants to merge 1 commit into
BlivionIaG wants to merge 1 commit into
Conversation
Remove unreferenced TunableOp step-3 drivers, the closed PR #30 compile-dispatch harness, the split-K source-swap audit, and other one-shot probes. Drop the stale test_startup_plan_cpu.py line from docs/rdna2/V620-CANDIDATE.md. Co-authored-by: Grok 4.7 <grok@x.ai> Signed-off-by: BlivionIaG <kev29lt@gmail.com>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Delete finished, unreferenced one-shot experiment scripts BlivionIaG added under
tools/in the last month. Deletion only, plus the one staletest_startup_plan_cpu.pyline indocs/rdna2/V620-CANDIDATE.md. No launcher, test, or committed reproduction recipe loses a script it points at.AI assistance was used (Cursor Grok 4.7). No model-output, accuracy, or serving change, so no model eval.
Not a duplicate
Open PR #42 (
cursor/dead-tooling-cleanup-6e7b) deletes the same scripts and also rewritesscripts/and bothtunableop_env.shfiles, and it leaves the staletest_startup_plan_cpu.pyline indocs/rdna2/V620-CANDIDATE.md. This PR does not touchscripts/,tunableop_env.sh,csrc/, or upstreamvllm/files, and it removes that one doc line. Other open PRs (#2, #10, #18, #23, #25, #31, #33, #35, #37, #39, #40, #41) do not modify these paths.Kept (not in this diff)
tools/rdna2_028/campaign_matrix.sh— reproduction recipe inbench_results/2026-09-30_campaign-matrix/SUMMARY.md.tools/rdna2_028/probe_w4a8_op.py,probe_real_weights.py,build_rocm_c_incr.sh— cited bybench_results/2026-09-29_w4a8-splitk-fix/SUMMARY.md.tools/rdna2_028/flashnext_w4a8_arm.shandscripts/serve_gfx1030_27b_dense.sh— cited bydocs/explore/w4a16-compile-dispatch/RESULTS-2026-09-30.md.tools/probe_greedy_correctness.py— loaded bytests/entrypoints/openai/test_probe_greedy_correctness.py.tools/rdna2_028/audit_split/split_old.txtandsplit_fixed.txt— not scripts and not on the delete list. Their only caller wasaudit_w4a16.sh.step0_*,exl3_analyze.py, open-PR files (serve_v620_baseline.sh,check_rdna_ar_native.py,qualify_tool_turns.py,probe_hetero_peer.py,pr33_*),tunableop_env.sh,scripts/, andVLLM_RDNA2_PREFILL_FORCE_*incsrc.No candidate was kept because of a live reproduction citation.
bench_results/2026-09-30_campaign-matrix/SUMMARY.mdstill namescampaign_3a_capture.shas the prior wrong design (line 23) and mentions a killedcampaign_3aserver whose intermediate rows were superseded (lines 140–145). The reproduction block there iscampaign_matrix.sh. That historical note was not rewritten.Pre-delete
rg -n <basename>(whole repo)Hits below are the script itself, a sibling on this delete list, the superseded SUMMARY note, or the one doc line removed in this PR.
campaign_3a_capture.shbench_results/2026-09-30_campaign-matrix/SUMMARY.md:23(prior wrong design)campaign_3bcd_arm.shcampaign_3bcd_curate.shcampaign_3d_freeze.shpr30_b1_probe.shpr30_b2_rocprof.sh:12(sibling)pr30_b2_rocprof.shpr30_b3_driver.shaudit_w4a16.shaudit_split_swap.pyaudit_w4a16.sh:58,62(sibling)probe_prefill_split.pyaudit_w4a16.sh:50(sibling)probe_force_split.pyprobe_gptq_k.pyparse_kernel_sass.pyprobe_model_inspect2.pyprobe_inmodel_layer.pyflashnext_w4a8_matrix.shtunableop_rows_e2e.shprobe_concurrent_greedy.pytunableop_rows_probe.pytest_startup_plan_cpu.pydocs/rdna2/V620-CANDIDATE.md:124(line deleted;tests/v1/worker/test_startup_plan.pydoes not exist)Test Plan
Test Result
Post-delete
rgof every deleted basename underscripts/,tests/,tools/, andvllm/: no hits (20/20 clean).Whole-repo
rgafter deletion: the only remaining hit isbench_results/2026-09-30_campaign-matrix/SUMMARY.md:23forcampaign_3a_capture.sh(the prior-wrong-design note).test_startup_plan_cpu.pyhas zero hits. Every other deleted basename has zero hits.No remaining shell script under
tools/rdna2_028names a deleted basename, sobash -nhad nothing to check..venv/bin/python -m pytest tests/tools -qdoes not collect on this CPU checkout.tests/conftest.pyimportstblib(then torch andvllm), and this environment has no project install:Diff is 21 files, 2055 deletions. The only non-deletion is the one-line removal in
docs/rdna2/V620-CANDIDATE.md.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing
Closed as duplicate of #42. Same dead-tooling deletions; #42 also covers the env-export trims and tunableop_env dedupe. Prefer #42.