Repository navigation
fix(rdna): follow-ups from the 2026-10-16 cleanup PRs (#101-#106) - #118
Open
BlivionIaG wants to merge 1 commit into
Open
BlivionIaG wants to merge 1 commit into
BlivionIaG wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Dead probe (#104)
tools/rdna2_028/probe_force_split.pysetVLLM_RDNA2_PREFILL_FORCE_SPLIT_K, whose only reader was removed in #104, so it silently ran the default config. Deleted the probe. No other references outsidebench_results/(history, left as is).2. Port notes (#102 vs #103)
docs/rdna2/v0.31.0-port-notes.mdlistedVLLM_BT_DEBUG,VLLM_MAMBA_COPY_DEBUG,DBG_VLLM_STEP_TIMINGas still read, and saidVLLM_BT_DEBUGwas kept. #103 removed all three readers. Both places fixed; the list now holds onlyVLLM_MOE_NAN_DEBUG,VLLM_LAYER_NAN_DEBUG(vllm/models/qwen4_exp/amd/model.py),VLLM_TRACE_PREFIX_CACHE,VLLM_DEBUG_PREFIX_HIT,VLLM_NO_PARTIAL_HASH(vllm/v1/core/kv_cache_coordinator.py), each verified by grep. A note says the other three were dropped in #103.3. TunableOp README (#101)
tunableop/README.mdstill named the deletedtools/rdna2/tunableop_env.shmirror (two places). Now points only attools/rdna2_028/tunableop_env.sh.4. Skip message (#106)
tests/kernels/quantization/test_gdn_prefill_kkt_rdna2.pyskipped unconditionally while telling readers to run it in isolation. It now skips unlessVLLM_RUN_GDN_KKT_HANG_TEST=1, and the message says how to run it and why it is skipped (recorded GDN GPU hang).tests/kernels/test_gdn_prefill_rdna2.pyhad the same unconditional skip on its hang test; it got the same opt-in (skipif).tools/rdna/port_v031/unit.shheader now documents the env var.Checks
grep -rnforprobe_force_split|VLLM_RDNA2_PREFILL_FORCE, the three removed knobs, andtools/rdna2/tunableop_env: only the references fixed here remain (excludingbench_results/).grep -rlfor the five kept knobs undervllm csrc tools: all still read.python3 -m py_compileon both edited test files: ok.uvx ruff checkanduvx ruff format --checkon both: passed.