Fix global crs codes lookup in discovery collections crs tests #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscoveryCollectionsDefaultCrs asserts that a `/collections` document complies with ``` Abstract Test 2: /conf/crs/default-crs Test Purpose: Verify that the list of supported CRSs includes the default CRS. Requirement: /req/crs/fc-md-crs-list B ``` but doesn't expand the collection's `#/crs` JSON pointer to the collections document crs list. This patch fixes it and adds unit tests to cover all possible cases.
DiscoveryCollectionsStorageCrs asserts that a `/collections` document
complies with
```
Abstract Test 3: /conf/crs/storageCrs
Test Purpose: Verify that the storage CRS identifier is a valid value
Test Method: For each collection object that includes a storageCrs property in the paths /collections and
/collections/{collectionId}, validate that the string is also found in the crs property of the collection or, in case
the crs property includes a value #/crs, in the global list of CRSs.
```
but doesn't expand the collection's `#/crs` JSON pointer to the collections
document crs list.
This patch fixes it and adds unit tests to cover all possible cases.
|
Closing as superseded by #255, issuing the pull request from the geoserver fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
DiscoveryCollectionsStorageCrslook up of global crsDiscoveryCollectionsStorageCrsasserts that a/collectionsdocument complies withbut doesn't expand the collection's
#/crsJSON pointer to the collections document crs list.This patch fixes it and adds unit tests to cover all possible cases.
Fix
DiscoveryCollectionsDefaultCrslook up of codes in the global crsDiscoveryCollectionsDefaultCrsasserts that a/collectionsdocument complies withbut doesn't expand the collection's
#/crsJSON pointer to the collections document crs list.This patch fixes it and adds unit tests to cover all possible cases.
Fixes #251