Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 2: CRS should fail if it key tests were skipped #184

Closed
jerstlouis opened this issue Nov 9, 2021 · 3 comments · Fixed by #211
Closed

Part 2: CRS should fail if it key tests were skipped #184

jerstlouis opened this issue Nov 9, 2021 · 3 comments · Fixed by #211
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jerstlouis
Copy link
Member

jerstlouis commented Nov 9, 2021

Describe the bug
Prior to the OoM issue (#181) being resolved, the tests reported our Part 2: CRS implementation as successful, even though it had skipped most tests because of Out of Memory failure, such as bbox-crs (which was not yet implemented).

To Reproduce
Difficult now that the OoM issue has been resolved, but see https://cite.opengeospatial.org/teamengine/reports/jerstlouis4/s0002/html/ .

CRS was reported as passed with only a single successful test:

Verify Requirement Class: Precondition: requirement class http://www.opengis.net/spec/ogcapi-features-2/1.0/req/crs must be implemented

Verify Collections Collection Crs Identifier Of Crs Property: Implements A.1 Discovery, Abstract Test 1 (Requirement /req/crs/crs-uri, /req/crs/fc-md-crs-list A, /req/crs/fc-md-storageCrs, /req/crs/fc-md-crs-list-global), crs property in the collection objects in the path /collections; java.util.NoSuchElementException: No value present
  
Verify Collections Collection Crs Identifier Of Storage Crs: Implements A.1 Discovery, Abstract Test 1 (Requirement /req/crs/crs-uri, /req/crs/fc-md-crs-list A, /req/crs/fc-md-storageCrs, /req/crs/fc-md-crs-list-global), storageCrs property in the collection objects in the path /collections; java.util.NoSuchElementException: No value present
 
Verify Collections Path Collection Crs Property Contains Default Crs: Implements A.1 Discovery, Abstract Test 2 (Requirement /req/crs/fc-md-storageCrs-valid-value), storageCrs property in the collection objects in the path /collections; java.util.NoSuchElementException: No value present
 
Verify Collections Path Collection Crs Property Contains Default Crs: Implements A.1 Discovery, Abstract Test 2 (Requirement /req/crs/fc-md-crs-list B), crs property contains default crs in the collection objects in the path /collections; java.util.NoSuchElementException: No value present

Expected behavior
Conformance classes should fail if key tests were skipped.

Screenshots
shouldFail

Additional context
Originally reported in #181

@dstenger
Copy link
Contributor

dstenger commented Nov 9, 2021

Thank you for reporting.

We will discuss in the CITE team how the mechanism can be improved here.

@dstenger
Copy link
Contributor

@jerstlouis We are currently working on this issue. Do you have a public test API to reproduce this issue?

@jerstlouis
Copy link
Member Author

@dstenger Sorry, no, because our public API tries to conform to the requirements.

But this should be really easy to verify from code inspection, ensuring that the conformance class fails if essential tests were skipped.

@bpross-52n bpross-52n linked a pull request Apr 27, 2023 that will close this issue
@dstenger dstenger added the bug Something isn't working label May 4, 2023
@dstenger dstenger assigned dstenger and unassigned bpross-52n May 10, 2023
@dstenger dstenger added this to the 1.5 milestone Jul 19, 2023
dstenger added a commit that referenced this issue Jul 21, 2023
@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to Done in CITE Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants