-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Update vs template for when multiple addons with identical class names are used. #5655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current solution:
can lead to getting the object files all over the place. In my case, I'm including files that are several directories above the project; For example, I have some addons outside the OF folder itself which leads to my include paths looking like this All of this weird path arrangements are to be able to keep OF as a submodule inside a project git repo; in our company we need to be able to clone projects easily, so we came up with a git repo structure where the project itself is in the main repo, and OF and whatever addons are required are added to the repo as submodules. This means we can't put anyhting inside the OF folder, thus having this ../../ paths all over the place. |
I propose we change it to :
Which leads to this obj file setup:
This create really deep folder structures, but it makes sure everything is contained within obj. |
I have no problems with any solution that continues to solve the original problem. The one issue I'd watch out for is paths getting too long. I've run into a number of very odd errors on windows that turns out to be the result of very long file paths (e.g. elliotwoods/ofxKinectForWindows2#72). So just something to keep an eye on. |
Hmm that is a good catch - ill try find a solution that doens't potentially create this problem |
Fixes openframeworks/projectGenerator#159
Fixes bakercp/ofxJSONRPC#10
See also bakercp/ofxJSONRPC#10