Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining problems in CI #123

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Fix remaining problems in CI #123

merged 2 commits into from
Jul 19, 2024

Conversation

j-wags
Copy link
Member

@j-wags j-wags commented Jul 18, 2024

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.82%. Comparing base (3d251ed) to head (5e1e22b).

Additional details and impacted files

@j-wags j-wags changed the title Fix CI Fix remaining problems in CI Jul 18, 2024
lilyminium
lilyminium approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @j-wags! I'll raise an issue to unpin if/when rdkit gets fixed.

@lilyminium lilyminium mentioned this pull request Jul 18, 2024
Closed
@j-wags j-wags merged commit b2bc55b into main Jul 19, 2024
62 checks passed
@j-wags j-wags deleted the fix-dev-ci branch July 19, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyminium lilyminium lilyminium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-wags @codecov-commenter @lilyminium