Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put footer at the bottom of the page + sign-in button on product page #7466

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

stephanegigandet
Copy link
Contributor

Fixes #7410 : the footer should be at the bottom, even if the page has little content. There were some strange issues with the top menu dropdown menu going under the Open Food Facts bar below, but it should now work.

image

Also fixed #7464

@stephanegigandet stephanegigandet requested a review from a team as a code owner October 10, 2022 14:59
@github-actions github-actions bot added CSS Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Oct 10, 2022
@stephanegigandet stephanegigandet merged commit e8b970e into redesign2 Oct 10, 2022
@stephanegigandet stephanegigandet deleted the footer-at-the-bottom branch October 10, 2022 16:21
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
18.5% 18.5% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant