Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Give priority to ingredients over category to estimate fruits/vegetable content for Nutri-Score #6600

Merged
merged 2 commits into from
Apr 13, 2022
Merged

fix: Give priority to ingredients over category to estimate fruits/vegetable content for Nutri-Score #6600

merged 2 commits into from
Apr 13, 2022

Conversation

stephanegigandet
Copy link
Contributor

  • changed the order for the source of the fruits/vegetable estimate, as the estimate from the category is less reliable (a lot of examples seen in a recent producer export: wrong category + too optimistic estimates for some categories).
  • added some tests

fixes #6598

@stephanegigandet stephanegigandet requested a review from a team as a code owner April 13, 2022 10:48
@stephanegigandet stephanegigandet added the 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore label Apr 13, 2022
@github-actions github-actions bot added Food.pm 🧪 tests and removed 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore labels Apr 13, 2022
@stephanegigandet stephanegigandet changed the title Give priority to ingredients over category to estimate fruits/vegetable content for Nutri-Score fix: Give priority to ingredients over category to estimate fruits/vegetable content for Nutri-Score Apr 13, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexgarel alexgarel merged commit 20bf2b3 into main Apr 13, 2022
@alexgarel alexgarel deleted the nutriscore branch April 13, 2022 14:41
@alexgarel alexgarel mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees
No one assigned
Labels
Food.pm 🧪 tests
Projects
None yet
Milestone
No milestone
2 participants
@stephanegigandet @alexgarel