Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the container image minimal #557

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Keep the container image minimal #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4908974
Keep the container image minimal
sks Nov 3, 2023
7d7d483
Review comment: Changing Integration test dockerfile
sks Nov 3, 2023
9cf92fb
Fix test with Entrypoint
sks Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ RUN apk add --no-cache git make build-base
ADD . .
RUN make build

FROM alpine

COPY --from=go_builder /go/src/github.com/openflagr/flagr/flagr .

ENV HOST=0.0.0.0
ENV PORT=18000
ENV FLAGR_DB_DBDRIVER=sqlite3
Expand All @@ -32,4 +36,5 @@ USER appuser
ADD --chown=appuser:appgroup ./buildscripts/demo_sqlite3.db /data/demo_sqlite3.db

EXPOSE 18000
CMD ./flagr

CMD "./flagr"
7 changes: 6 additions & 1 deletion integration_tests/Dockerfile-Integration-Test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,16 @@ RUN apk add --no-cache git make build-base
ADD . .
RUN make build

FROM alpine

COPY --from=go_builder /go/src/github.com/openflagr/flagr/flagr .

ENV HOST=0.0.0.0
ENV PORT=18000
ENV FLAGR_DB_DBDRIVER=sqlite3
ENV FLAGR_RECORDER_ENABLED=false
RUN addgroup -S appgroup && adduser -S appuser -G appgroup
USER appuser
EXPOSE 18000
CMD ./flagr
sks marked this conversation as resolved.
Show resolved Hide resolved

CMD "./flagr"
4 changes: 2 additions & 2 deletions integration_tests/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ version: "3.6"

networks:
default:
external:
name: flagr_integration_tests
external: true
name: flagr_integration_tests

services:
mysql:
Expand Down
Loading