Fix 401 jwt middleware handling #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzhuojie
force-pushed
the
zz/correctly-handle-401-jwt
branch
from
7704a47 to
ca09d76
Compare
zhouzhuojie
commented
Sep 13, 2018
| @@ -9,17 +9,6 @@ import ( | |||
| "github.com/stretchr/testify/assert" | |||
| ) | |||
|
|
|||
| func TestGetEvalCacheStart(t *testing.T) { | |||
There was a problem hiding this comment.
remove it since it tests nothing and introduces a data race
rstratton
approved these changes
Sep 13, 2018
zhouzhuojie
force-pushed
the
zz/correctly-handle-401-jwt
branch
from
ca09d76 to
ed3ac2a
Compare
zhouzhuojie
force-pushed
the
zz/correctly-handle-401-jwt
branch
from
ed3ac2a to
323e7ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we set to 401 unauthorized for jwt auth, let the client handles the 401 itself