-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flagr key #159
Add flagr key #159
Conversation
@@ -1,5 +1,5 @@ | |||
mysql: | |||
image: mysql:5.7 | |||
image: mysql:5.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious what's the reason to downgrade mysql?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match the mysql version of RDS, I was testing the migration locally with docker
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 93.37% 92.89% -0.48%
==========================================
Files 25 25
Lines 1252 1309 +57
==========================================
+ Hits 1169 1216 +47
- Misses 56 63 +7
- Partials 27 30 +3
Continue to review full report at Codecov.
|
7de62eb
to
8294da4
Compare
8294da4
to
19ba256
Compare
Description
Support
flagKey
in the following endpoints/flags?key=<key>
/flags
(create flagKey, if empty, use a random one)flags/<id>
(update/save flagKey)/evaluation
/evaluation/batch
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
Screenshots