Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

no root user + docker ignore dockerfile #52

Merged
merged 2 commits into from
Nov 22, 2021

Conversation

glutamatt
Copy link
Contributor

Description

security recommendations are to avoid root in containers

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zhouzhuojie
Copy link
Contributor

thanks, let's also change this file https://github.com/openflagr/flagr/blob/main/integration_tests/Dockerfile-Integration-Test

@glutamatt
Copy link
Contributor Author

@codecov-commenter
Copy link

Codecov Report

Merging #52 (cc3cbfe) into main (1694d8e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files          27       27           
  Lines        2174     2174           
=======================================
  Hits         1773     1773           
  Misses        314      314           
  Partials       87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1694d8e...cc3cbfe. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit d4745ab into openflagr:main Nov 22, 2021
@glutamatt glutamatt deleted the noroot branch November 22, 2021 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants