This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make sure that the distribution result from eval flags are as close as expected with the hashing function that flagr is using (i.e. CRC32). In these tests, we are targeting 1e6 samples and a 0.5% error bar (usually it's less than 0.1%, e.g. 0.0436% from the secure random key generator, but for reducing the flakiness of unit tests, we are raising the threshold to 0.5%).
Motivation and Context
Address some of the concerns raised from openflagr/flagr#464
How Has This Been Tested?
unit tests
Types of changes
Checklist: