Don't compile armv7 if the architecture excluded it.
#1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcagabe19
reviewed
Jan 16, 2024
MAJigsaw77
changed the title
armv7 if the architecture excluded it.
|
Well now there's no guarantee that any architecture will be selected. Maybe we need something like this at the end? if (architectures.length == 0) architectures.push(Architecture.ARM64); |
Right |
|
Maybe was better to also warn the user but ok |
|
That would be fine too. I don't have any reasons to prefer either. |
|
I think is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the ndll was excluded from being added to the app, now that part of the compilation won't even happen anymore decreasing the compile time.