Skip to content

Audio pitch change implementation #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 12, 2022
Merged

Audio pitch change implementation #1510

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2ffb6ee
initial pitch stuff
ninjamuffin99 Dec 18, 2021
b3dd46e
HTML5 backend pitch
ninjamuffin99 Dec 18, 2021
cd2ab16
following structure of other stuff
ninjamuffin99 Dec 18, 2021
f65eedf
Calculate time remaining based on pitch
player-03 Dec 29, 2021
809ba2f
Add pitch functions to `FlashAudioSource`
player-03 Dec 29, 2021
f46ed3d
Standardize setters in `NativeAudioSource`.
player-03 Jan 8, 2022
c328d0c
Make sure `NativeAudioSource.handle` is non-null.
player-03 Jan 8, 2022
8e46831
Remove redundant code.
player-03 Jan 8, 2022
07e6525
Add missing `#if` tag.
player-03 Jan 10, 2022
878982e
Never skip `setCurrentTime()`.
player-03 Jan 26, 2022
cda9d3a
Add missing feature warning to `FlashAudioSource`.
player-03 Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/lime/_internal/backend/native/NativeAudioSource.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ class NativeAudioSource
timer.stop();
}

var timeRemaining = getLength() - value;
var timeRemaining = Std.int((getLength() - getCurrentTime()) / getPitch());

if (timeRemaining > 0)
{
Expand Down Expand Up @@ -483,7 +483,7 @@ class NativeAudioSource
timer.stop();
}

var timeRemaining = value - getCurrentTime();
var timeRemaining = Std.int((getLength() - getCurrentTime()) / getPitch());

if (timeRemaining > 0)
{
Expand Down Expand Up @@ -514,6 +514,22 @@ class NativeAudioSource
{
AL.sourcef(handle, AL.PITCH, value);

if (playing)
{
if (timer != null)
{
timer.stop();
}

var timeRemaining = Std.int((getLength() - getCurrentTime()) / getPitch());

if (timeRemaining > 0)
{
timer = new Timer(timeRemaining);
timer.run = timer_onRun;
}
}

return getPitch();
}

Expand Down