Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a way to run tests in parallel #1171

Closed
wants to merge 6 commits into from
Closed

Introduce a way to run tests in parallel #1171

wants to merge 6 commits into from

Conversation

bonjourmauko
Copy link
Member

Fixes #1025

Technical changes

  • Introduce a way to run test in parallel.
  • Check openfisca test --help for usage instructions.

@bonjourmauko bonjourmauko added level:starter Suited for beginners and new contributors kind:ci Continuous ops, integration & deployment labels Dec 6, 2022
@bonjourmauko bonjourmauko requested review from sandcha, benoit-cty and a team December 6, 2022 23:55
@openfisca openfisca deleted a comment from coveralls Dec 6, 2022
@bonjourmauko bonjourmauko changed the title Introduce a way to run test in parallel Introduce a way to run tests in parallel Dec 7, 2022
MattiSG
MattiSG reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #1025, @benoit-cty mentioned issues with Xdist that were likely to come up with pytest-parallel. Do we not have them here?

The suggested library is not maintained: kevlened/pytest-parallel#104. Our stack is already suffering from outdated dependencies and I don't find it wise to add to this.

What is the performance gain we get from this implementation on some large models?

.github/workflows/workflow.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
openfisca_core/tools/test_runner.py Outdated Show resolved Hide resolved
@bonjourmauko bonjourmauko requested a review from MattiSG December 13, 2022 22:33
@bonjourmauko
Copy link
Member Author

In #1025, @benoit-cty mentioned issues with Xdist that were likely to come up with pytest-parallel. Do we not have them here?

The suggested library is not maintained: kevlened/pytest-parallel#104. Our stack is already suffering from outdated dependencies and I don't find it wise to add to this.

What is the performance gain we get from this implementation on some large models?

Fair enough. Performance is only remarkable for county packages like France. Implementing xdist requires changes to the test command. I propose we deal with those, needed nonetheless to upgrade to newest pytest.

@bonjourmauko bonjourmauko deleted the parallel branch December 13, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandcha sandcha Awaiting requested review from sandcha

@benoit-cty benoit-cty Awaiting requested review from benoit-cty

@MattiSG MattiSG Awaiting requested review from MattiSG

Assignees
No one assigned
Labels
kind:ci Continuous ops, integration & deployment level:starter Suited for beginners and new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce a way to run test in parallel
2 participants
@bonjourmauko @MattiSG