Skip to content

fix(python): reuse ssl context in the python sync client #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhamzeh merged 2 commits into from
Sep 12, 2025
Merged

fix(python): reuse ssl context in the python sync client #607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba7bd3a
Reuse ssl context in the sync client
wadells Sep 4, 2025
4598242
Remove ca_certs, cert_file, and key_file params
wadells Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions config/clients/python/template/src/sync/rest.py.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,19 @@ class RESTClientObject:
:param pools_size: The number of connection pools to use.
:param maxsize: The maximum number of connections per pool.
"""
if hasattr(configuration, "verify_ssl") and configuration.verify_ssl:
cert_reqs = ssl.CERT_REQUIRED
else:
cert_reqs = ssl.CERT_NONE

# Reuse SSL context to mitigate OpenSSL 3.0+ performance issues
# See: https://github.com/openssl/openssl/issues/17064
ssl_context = ssl.create_default_context(cafile=configuration.ssl_ca_cert)

if configuration.cert_file:
ssl_context.load_cert_chain(
configuration.cert_file, keyfile=configuration.key_file
)

if not configuration.verify_ssl:
ssl_context.check_hostname = False
ssl_context.verify_mode = ssl.CERT_NONE
Comment thread
wadells marked this conversation as resolved.

addition_pool_args = {}

Expand Down Expand Up @@ -181,10 +190,7 @@ class RESTClientObject:
urllib3.ProxyManager(
num_pools=pools_size,
maxsize=maxsize,
cert_reqs=cert_reqs,
ca_certs=configuration.ssl_ca_cert,
cert_file=configuration.cert_file,
key_file=configuration.key_file,
ssl_context=ssl_context,
proxy_url=configuration.proxy,
proxy_headers=configuration.proxy_headers,
**addition_pool_args,
Expand All @@ -196,10 +202,7 @@ class RESTClientObject:
self.pool_manager = urllib3.PoolManager(
num_pools=pools_size,
maxsize=maxsize,
cert_reqs=cert_reqs,
ca_certs=configuration.ssl_ca_cert,
cert_file=configuration.cert_file,
key_file=configuration.key_file,
ssl_context=ssl_context,
**addition_pool_args,
)

Expand Down
Loading