Skip to content

feat: python SDK - #22

Merged
adriantam merged 24 commits into
mainfrom
feat/python_new
Sep 25, 2022
Merged

feat: python SDK#22
adriantam merged 24 commits into
mainfrom
feat/python_new

Conversation

@adriantam

@adriantam adriantam commented Aug 22, 2022

Copy link
Copy Markdown
Member

Description

Provide initial version of Python SDK. It has all features of other SDK except the authentication piece.

References

Review Checklist

  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam added the python-sdk Affects the Python SDK label Aug 22, 2022
@adriantam adriantam self-assigned this Aug 22, 2022
@adriantam
adriantam requested a review from a team as a code owner August 22, 2022 22:40
@adriantam adriantam changed the title Feat/python new feat: python SDK Aug 22, 2022
@adriantam

Copy link
Copy Markdown
Member Author

To FIX: The generated SDK README's create_store has the wrong text
i) Should not require store_id
ii) create_store needs to pass in name of store via CreateStoreRequest

Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/workflows/tests.yml Outdated
Comment thread Makefile Outdated
Comment thread config/clients/python/template/README_calling_api.mustache Outdated
Comment thread config/clients/python/template/README_license_disclaimer.mustache Outdated
Comment thread config/clients/python/template/api_test.mustache
Comment thread config/clients/python/template/__init__package.mustache Outdated
Comment thread config/clients/python/template/configuration.mustache Outdated
Comment thread config/clients/python/template/gitignore.mustache
@adriantam

Copy link
Copy Markdown
Member Author

To FIX: The generated SDK README's create_store has the wrong text i) Should not require store_id ii) create_store needs to pass in name of store via CreateStoreRequest

This is fixed.

Comment thread Makefile Outdated
Comment thread config/clients/python/template/.github/workflows/main.yaml
Comment thread config/clients/python/template/tornado/rest.mustache
Comment thread config/clients/python/template/python_doc_auth_partial.mustache Outdated
Comment thread config/clients/python/template/README_calling_api.mustache
Comment thread config/clients/python/config.overrides.json Outdated
Comment thread config/clients/python/template/README_installation.mustache Outdated
Comment thread config/clients/python/template/rest.mustache
Comment thread config/clients/python/template/setup.mustache
Comment thread config/clients/python/patches/OpenFgaApi.md.patch Outdated
Comment thread config/clients/python/template/asyncio/rest.mustache
Comment thread config/clients/python/template/python_doc_auth_partial.mustache Outdated
Comment thread config/clients/python/template/model_utils_test.mustache Outdated
Comment thread config/clients/python/template/README_installation.mustache Outdated
@adriantam
adriantam requested a review from rhamzeh August 29, 2022 19:59
Comment thread config/clients/python/template/partial_header.mustache
@adriantam
adriantam requested a review from rhamzeh September 8, 2022 18:11
rhamzeh
rhamzeh previously approved these changes Sep 21, 2022
feat: python SDK adding retry to OpenFGA upon 429
@adriantam
adriantam merged commit 88770b3 into main Sep 25, 2022
@adriantam
adriantam deleted the feat/python_new branch September 25, 2022 02:30
SoulPancake pushed a commit that referenced this pull request Nov 20, 2025
<!-- Thanks for opening a PR! Here are some quick tips:
If this is your first time contributing, [read our Contributing
Guidelines](https://github.com/openfga/.github/blob/main/CONTRIBUTING.md)
to learn how to create an acceptable PR for this repo.
By submitting a PR to this repository, you agree to the terms within the
[OpenFGA Code of
Conduct](https://github.com/openfga/.github/blob/main/CODE_OF_CONDUCT.md)

If your PR is under active development, please submit it as a "draft".
Once it's ready, open it up for review.
-->

<!-- Provide a brief summary of the changes -->

## Description
<!-- Provide a detailed description of the changes -->

## References
<!-- Provide a list of any applicable references here (Github Issue,
[OpenFGA RFC](https://github.com/openfga/rfcs), other PRs, etc..) -->
Closes #22

## Review Checklist
- [x] I have clicked on ["allow edits by
maintainers"](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork).
- [ ] I have added documentation for new/changed functionality in this
PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev)
[Provide a link to any relevant PRs in the references section above]
- [x] The correct base branch is being used, if not `main`
- [ ] I have added tests to validate that the change in functionality is
working as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python-sdk Affects the Python SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants