Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update order of middleware #662

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix: update order of middleware #662

merged 1 commit into from
Mar 29, 2023

Conversation

adriantam
Copy link
Member

Description

Change so that we get request id first. This allows us usage of request id in validation layer.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Change so that we get request id first.  This allows us usage of request id
in validation layer.
@adriantam adriantam requested a review from a team as a code owner March 28, 2023 23:08
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (bdab1a3) 84.65% compared to head (55cff74) 84.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
+ Coverage   84.65%   84.67%   +0.01%     
==========================================
  Files          88       88              
  Lines       13843    13843              
==========================================
+ Hits        11719    11721       +2     
+ Misses       1742     1740       -2     
  Partials      382      382              
Impacted Files Coverage Δ
cmd/run/run.go 62.17% <100.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adriantam adriantam merged commit fcacdb5 into main Mar 29, 2023
@adriantam adriantam deleted the fix/req_id_first branch March 29, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants