Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version in CLI #625

Merged
merged 4 commits into from
Mar 13, 2023
Merged

feat: add version in CLI #625

merged 4 commits into from
Mar 13, 2023

Conversation

adriantam
Copy link
Member

@adriantam adriantam commented Mar 10, 2023

Description

Allow printing out of version in CLI

adriantam@C02F5002MD6P openfga % ./openfga
A high performance and flexible authorization/permission engine built for developers and inspired by Google Zanzibar.

OpenFGA is designed to make it easy for developers to model their application permissions, and to add and integrate fine-grained authorization into their applications.
Complete documentation is available at https://openfga.dev.

Usage:
  openfga [command]

Available Commands:
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  migrate     Run database schema migrations needed for the OpenFGA server
  run         Run the OpenFGA server
  version     Return the OpenFGA version

Flags:
  -h, --help   help for openfga

Use "openfga [command] --help" for more information about a command.
adriantam@C02F5002MD6P openfga % ./openfga  version
2023/03/10 15:02:35 OpenFGA Version dev

References

N/A

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam requested a review from a team as a code owner March 10, 2023 20:02
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 51.28% and project coverage change: -0.11 ⚠️

Comparison is base (42ecb9c) 84.32% compared to head (0511d4a) 84.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   84.32%   84.21%   -0.11%     
==========================================
  Files          86       87       +1     
  Lines       13647    13668      +21     
==========================================
+ Hits        11508    11511       +3     
- Misses       1759     1777      +18     
  Partials      380      380              
Impacted Files Coverage Δ
cmd/openfga/main.go 0.00% <0.00%> (ø)
cmd/version.go 0.00% <0.00%> (ø)
pkg/testfixtures/storage/mysql.go 83.33% <75.00%> (-0.33%) ⬇️
pkg/testfixtures/storage/postgres.go 82.85% <75.00%> (-0.32%) ⬇️
pkg/typesystem/typesystem.go 86.28% <92.85%> (+0.21%) ⬆️
pkg/server/commands/write_authzmodel.go 90.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

miparnisari
miparnisari previously approved these changes Mar 10, 2023
Copy link
Contributor

@jon-whit jon-whit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment

@adriantam adriantam requested a review from jon-whit March 13, 2023 18:34
@adriantam adriantam merged commit 13c14a8 into main Mar 13, 2023
@adriantam adriantam deleted the feat/version_cmd branch March 13, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants