feat: support subject validation when using OIDC AuthN mode #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1784 +/- ##
==========================================
- Coverage 87.63% 87.63% -0.00%
==========================================
Files 101 101
Lines 9812 9824 +12
==========================================
+ Hits 8598 8608 +10
Misses 857 857
- Partials 357 359 +2 ☔ View full report in Codecov by Sentry. |
adriantam
previously approved these changes
Jul 23, 2024
miparnisari
suggested changes
Jul 23, 2024
Co-authored-by: Maria Ines Parnisari <[email protected]>
miparnisari
reviewed
Jul 24, 2024
miparnisari
reviewed
Jul 24, 2024
|
Hi @miparnisari Thanks for your detailed code review, all suggestions applied |
miparnisari
approved these changes
Jul 29, 2024
|
@miparnisari @Code2Life please update the docs here after this is merged https://openfga.dev/docs/getting-started/setup-openfga/configure-openfga#oidc |
adriantam
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support subject validation when using OIDC AuthN mode, using OPENFGA_AUTHN_OIDC_SUBJECTS env variable or authn-oidc-subjects config.
Description
User story:
As a platform owner, I wanna limit which services could call OpenFGA, so that to avoid unexpected model or relations modifications by none eligible services.
For example, in a Kubernetes cluster, even if Kubernetes's OIDC configured as AuthN approach, any pod using any service account could call OpenFGA. It introduces security risks because no limits of subjects, namely service account.
With subjects limit feature added, platform owner could restrict services authenticated by Kuberenetes or other OIDC providers. For instance, in Kubernetes, the flag/env-var could be configured like this: "system:serviceaccount:{allowed-namespace}:{allowed-kubernetes-service-account}"
References
Review Checklist
main