-
Notifications
You must be signed in to change notification settings - Fork 25
feat: Streamed list objects SDK support #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
3a3641a
aff7424
cbc928e
6a79981
02153f9
be65362
86fcbc7
fde2193
c13c9b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1175,6 +1175,10 @@ public CompletableFuture<Stream<StreamedListObjectsResponse>> streamedListObject | |
| Stream<StreamedListObjectsResponse> stream = java.util.stream.StreamSupport.stream( | ||
| ((Iterable<StreamedListObjectsResponse>) () -> iterator).spliterator(), false); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: do we need to cast to |
||
| return stream.onClose(() -> { | ||
| try { | ||
| iterator.close(); | ||
| } catch (java.io.IOException ignore) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we be ignoring exceptions closing the iterator or response body? Seems like it could cause issues to swallow these errors. If we can recover we should, if not can we throw back to caller with applicable information? Or if there is good reason to swallow exceptions, let's add clear code comment explaining why. |
||
| } | ||
| try { | ||
| srb.close(); | ||
| } catch (java.io.IOException ignore) { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.