fix: Do not ignore request level storeId in non-transactional write - #162
Merged
ewanharris merged 1 commit intoJan 27, 2025
Merged
fix: Do not ignore request level storeId in non-transactional write#162ewanharris merged 1 commit into
ewanharris merged 1 commit into
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (25.71%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 25.68% 25.71% +0.02%
==========================================
Files 104 104
Lines 12577 12582 +5
==========================================
+ Hits 3231 3236 +5
Misses 9075 9075
Partials 271 271 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Do not ignore request level storeId override in non-transactional write
Description
Currently, the request level store ID is ignored in non-transactional write requests, resulting in the error "storeId is required and must be specified". This PR fixes the issue by passing the storeId to the WriteExecute call.
This PR
Review Checklist
main