chore: remove dependecy to OpenTelemetry.Api - #100
Merged
rhamzeh merged 1 commit intoMar 28, 2025
Conversation
The committers listed above are authorized under a signed CLA. |
As the SDK is not using features from OpenTelemetry Api the dependency is not needed. The instrumentation of the SDK is done via dotnet mechanism (System.Diagnostic). The appliction which use the SDK should manage and configure the OpenTelemetry packages
m4tchl0ck
force-pushed
the
Remove_reference_to_OpenTelemetry
branch
from
March 14, 2025 16:09
1455f93 to
d3f50b9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (33.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 33.00% 33.00%
=======================================
Files 128 128
Lines 6387 6387
Branches 840 840
=======================================
Hits 2108 2108
Misses 4099 4099
Partials 180 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks for the PR @m4tchl0ck! Apologies if it takes a bit to get merged, we're trying to clear up some blockers in the changes we have queued for .NET that are delaying things |
rhamzeh
approved these changes
Mar 28, 2025
rhamzeh
changed the title
rhamzeh
pushed a commit
to openfga/sdk-generator
that referenced
this pull request
Mar 28, 2025
As the SDK is not using features from OpenTelemetry Api the dependency is not needed. The instrumentation of the SDK is done via dotnet mechanism (System.Diagnostic). The appliction which use the SDK should manage and configure the OpenTelemetry packages Backport of openfga/dotnet-sdk#100
This was referenced Mar 28, 2025
rhamzeh
pushed a commit
to openfga/sdk-generator
that referenced
this pull request
Mar 28, 2025
As the SDK is not using features from OpenTelemetry Api the dependency is not needed. The instrumentation of the SDK is done via dotnet mechanism (System.Diagnostic). The appliction which use the SDK should manage and configure the OpenTelemetry packages Backport of openfga/dotnet-sdk#100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the SDK is not using features from OpenTelemetry Api the dependency is not needed.
Description
The instrumentation of the SDK is done via dotnet mechanism (System.Diagnostic).
The appliction which use the SDK should manage and configure the OpenTelemetry packages.
Review Checklist
main