Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PUT HTTP verb for update endpoint #4

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Use PUT HTTP verb for update endpoint #4

merged 1 commit into from
Sep 27, 2017

Conversation

johnmccabe
Copy link
Contributor

@johnmccabe johnmccabe commented Sep 26, 2017

This PR is part of a group of 3:

Description

This commit switches the verb used for updates from the non-HTTP UPDATE to PUT.

Motivation and Context

UPDATE is not a valid HTTP verb, the correct verb to use for updates is PUT (as pointed out by @imeoer - thx!)

How Has This Been Tested?

  • @alexellis have not tested this yet, can't see where its being used?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This commit uses the PUT HTTP verb for updates, relates to the following
PRs:

- openfaas/faas-cli#123
- openfaas/faas#208

Signed-off-by: John McCabe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants