Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dependency management from glide to vndr #39

Merged
merged 2 commits into from
Aug 20, 2017
Merged

Migrate dependency management from glide to vndr #39

merged 2 commits into from
Aug 20, 2017

Conversation

johnmccabe
Copy link
Contributor

@johnmccabe johnmccabe commented Aug 20, 2017

Description

This PR replaces Glide with Vndr for consistency with the main project.

Motivation and Context

Updating for consistency with the FaaS project.

  • I have raised an issue to propose this change

How Has This Been Tested?

Successfully built client locally using updated vendor directory (has removed unused packages/files).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This commit replaces the current `glide.yaml` and `glide.lock` replacing
them with `vendor.conf` pinned to the same git shas.

This is to bring dependency management in the cli into line with that
used in the main project.

Signed-off-by: John McCabe <[email protected]>
This commit runs `vndr` against the current `vendor` dir to remove
unused code.

Signed-off-by: John McCabe <[email protected]>
@alexellis alexellis merged commit 8555f01 into openfaas:master Aug 20, 2017
@alexellis
Copy link
Member

Good idea. I thought i had done this already - it probably shows how little the cli deps change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants