Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deletion error handling #192

Merged
merged 2 commits into from
Oct 31, 2017
Merged

Update deletion error handling #192

merged 2 commits into from
Oct 31, 2017

Conversation

alexellis
Copy link
Member

Signed-off-by: Alex Ellis [email protected]

Update deletion error handling

Description

Returns an error and exits if any of the functions get an error deleting in a stack.

Motivation and Context

  • I have raised an issue to propose this change (required)

openfaas/faas-netes#66

How Has This Been Tested?

With latest release of faas-netes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexellis alexellis self-assigned this Oct 27, 2017
@alexellis alexellis merged commit 194830b into master Oct 31, 2017
@alexellis alexellis deleted the deletehandling branch May 23, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant