Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use green logo on windows #150

Merged
merged 1 commit into from
Oct 9, 2017
Merged

Use green logo on windows #150

merged 1 commit into from
Oct 9, 2017

Conversation

johnmccabe
Copy link
Contributor

Description

This PR sets the version logo colour to green so as to avoid clashing with the Powershell default blue.

Motivation and Context

How Has This Been Tested?

Tested on OSX and Windows 10
powershell

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@johnmccabe
Use green logo on windows
d55e26b 
This commit sets the version logo colour to green so as to avoid
clashing with the Powershell default blue.

Signed-off-by: John McCabe <[email protected]>
@johnmccabe johnmccabe changed the title Use green logo on windows #149 Use green logo on windows Oct 8, 2017
@johnmccabe johnmccabe changed the title #149 Use green logo on windows Use green logo on windows Oct 8, 2017
@alexellis
Copy link
Member

Derek add label: skill/beginner

alexellis
alexellis approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 7d3026f into openfaas:master Oct 9, 2017
@johnmccabe johnmccabe mentioned this pull request Jan 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnmccabe @alexellis