Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constant for default gateway strings #102

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Use constant for default gateway strings #102

merged 1 commit into from
Sep 15, 2017

Conversation

itscaro
Copy link
Contributor

@itscaro itscaro commented Sep 14, 2017 •
edited
Loading

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexellis
Copy link
Member

Looks like a good change. I'll merge.

@alexellis alexellis merged commit e71ae41 into openfaas:master Sep 15, 2017
@alexellis alexellis mentioned this pull request Sep 15, 2017
Closed
@itscaro itscaro deleted the constant-for-default-gateway branch September 15, 2017 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itscaro @alexellis