Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate version from command version #208

Closed
Lewiscowles1986 opened this issue Nov 6, 2017 · 0 comments · Fixed by #209
Closed

Separate version from command version #208

Lewiscowles1986 opened this issue Nov 6, 2017 · 0 comments · Fixed by #209

Comments

@Lewiscowles1986
Copy link
Contributor

Lewiscowles1986 commented Nov 6, 2017

Pre-commit to #166

Expected Behaviour

Version command works as-is.

Current Behaviour

Not modified

Possible Solution

Pending PR

Steps to Reproduce (for bugs)

faas-cli version

Context

Merging #166 keeps stalling, lets get this done separately. We can then push the user-agent (which uses version) or push without user-agent using version and either close this or integrate later.

Your Environment

  • Docker version docker version (e.g. Docker 17.0.05 ): 17.09.0-ce

  • Are you using Docker Swarm or Kubernetes (FaaS-netes)? swarm

  • Operating System and version (e.g. Linux, Windows, MacOS): linux (should work for all, known brew edits needed)

  • Link to your project or a code example to reproduce issue: N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant