Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Set User-Agent: for all HTTP requests to identify FaaS-CLI #166

Closed
alexellis opened this issue Oct 14, 2017 · 5 comments
Closed

Proposal: Set User-Agent: for all HTTP requests to identify FaaS-CLI #166

alexellis opened this issue Oct 14, 2017 · 5 comments
Labels
hacktoberfest

Comments

@alexellis
Copy link
Member

Proposal: Set User-Agent: for all HTTP requests to identify FaaS-CLI

Expected Behaviour

FaaS-CLI should identify itself through a standard HTTP header.

Current Behaviour

Go-http-client/2.0

Possible Solution

Add headers via Golang calls. See PR in motion #165
@Lewiscowles1986
Copy link
Contributor

got it, thanks @alexellis should I base off of your PR or master?

@alexellis
Copy link
Member Author

My PR I'd say - you will need the changes I believe.

@Lewiscowles1986
Copy link
Contributor

I'm thinking that I can relocate version to it's own package (it's already injected on build for command version)

I'm not that great at go, but I think I'm nearly ready

@Lewiscowles1986
Copy link
Contributor

okay I'm sure it's ready. I'll rebase against yours and merge once complete 👍

This was referenced Oct 14, 2017
Closed
Closed
@Lewiscowles1986 Lewiscowles1986 mentioned this issue Nov 6, 2017
Closed
@alexellis
Copy link
Member Author

Completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Blocked] Added User Agent With Version
2 participants
@Lewiscowles1986 @alexellis