OEL-2677: Backwards compatible solution for typo.#708
Merged
tibi2303 merged 1 commit intodevelopmentfrom Nov 24, 2025
Merged
Conversation
Closed
|
🚀 Deployed on https://preview-708--oelibrary.netlify.app |
piotrsmykaj
force-pushed
the
OEL-2677-#default#
branch
from
ccaca97 to
b9e8396
Compare
donquixote
reviewed
Nov 19, 2025
| {% set _fullscreen_responsive = fullscreen_responsive|default('') %} | ||
| {% set _static_backdrop = static_backdrop ?? false %} | ||
| {% set _verticaly_centered = verticaly_centered ?? false %} | ||
| {% set _vertically_centered = vertically_centered ?? verticaly_centered ?? false %} |
Collaborator
There was a problem hiding this comment.
Nice fallback!
Will the spell checker still complain about this?
(or maybe this was about spell checker in oebt, not here)
Collaborator
There was a problem hiding this comment.
Also could we emit some kind of deprecation notice? (I guess not)
Collaborator
Author
There was a problem hiding this comment.
no, we dont have anything that can throw deprecation warnings. :(
donquixote
approved these changes
Nov 19, 2025
donquixote
approved these changes
Nov 19, 2025
tibi2303
force-pushed
the
OEL-2677-#default#
branch
from
b9e8396 to
18513da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.