Skip to content
This repository was archived by the owner on Feb 14, 2021. It is now read-only.

Add create2 under kip4 feature flag#12

Merged
NikVolf merged 2 commits into
masterfrom
kip4
Aug 6, 2018
Merged

Add create2 under kip4 feature flag#12
NikVolf merged 2 commits into
masterfrom
kip4

Conversation

@sorpaas
Copy link
Copy Markdown
Contributor

@sorpaas sorpaas commented Aug 6, 2018

rel openethereum/parity-ethereum#9277

When feature kip4 is enabled, add the create2 function.

@sorpaas sorpaas requested review from NikVolf and pepyakin August 6, 2018 07:37
Copy link
Copy Markdown
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread src/ext.rs Outdated
pub fn create(endowment: *const u8, code_ptr: *const u8, code_len: u32, result_ptr: *mut u8) -> i32;

#[cfg(feature = "kip4")]
pub fn create2(endowment: *const u8, salt: *const u8, code_ptr: *const u8, code_len: u32, result_ptr: *mut u8) -> i32;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wrap it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants