This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Remove tendermint engine support#9980
Merged
Merged
Conversation
sorpaas
added
A0-pleasereview 🤓
sorpaas
added
A3-inprogress ⏳
sorpaas
added
A0-pleasereview 🤓
ordian
approved these changes
Nov 28, 2018
ordian
added
A8-looksgood 🦄
5chdn
approved these changes
Nov 28, 2018
5chdn
added
the
B7-releasenotes 📜
niklasad1
pushed a commit
that referenced
this pull request
Dec 16, 2018
* Remove tendermint engine support * Remove tendermint test json spec * Fix ethcore test compile * Remove tendermint test in sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current tendermint engine is unmaintained, and was reported to be broken. This PR removes tendermint engine code. Integration with rhododendro BFT as replacement for tendermint is planned in the (really short-term) future.