Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

chore(eip712): remove unused failure-derive#9958

Merged
ascjones merged 1 commit into
masterfrom
chore/eip712-remove-unused-failure-derrive
Nov 23, 2018
Merged

chore(eip712): remove unused failure-derive#9958
ascjones merged 1 commit into
masterfrom
chore/eip712-remove-unused-failure-derrive

Conversation

@niklasad1
Copy link
Copy Markdown
Collaborator

No description provided.

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies. labels Nov 23, 2018
Copy link
Copy Markdown
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I thought we'd need to use #[macro_use] on extern crate failure;, but it seems to work w/o it.

@ordian ordian added this to the 2.3 milestone Nov 23, 2018
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 23, 2018
@ascjones ascjones merged commit 1fdfa1e into master Nov 23, 2018
@niklasad1 niklasad1 deleted the chore/eip712-remove-unused-failure-derrive branch November 23, 2018 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants