This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Make CALLCODE to trace value to be the code address#9881
Merged
Conversation
sorpaas
added
A0-pleasereview 🤓
tomusdrw
added
the
B7-releasenotes 📜
andresilva
approved these changes
Nov 9, 2018
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
LGTM. Since this changes the behavior of the trace not sure if we should backport it (although we backported this change when we did it for DELEGATECALL). Either way the changed behavior should be documented in the release notes.
sorpaas
removed
B0-patch-stable 🕷
Collaborator
Author
|
Just a note on re-syncing: nothing would break if a node does not re-sync, it would just have old tracing data using the old scheme, and new tracing data using the new scheme. So I'd say re-syncing is only required if a node really wants to fix its older data. |
sorpaas
added
A8-looksgood 🦄
ascjones
approved these changes
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9878