Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Revert "prevent zero networkID (#9763)" #9815

Merged
sorpaas merged 1 commit into from
Oct 26, 2018
Merged

Revert "prevent zero networkID (#9763)" #9815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions json/src/spec/params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ pub struct Params {

/// Network id.
#[serde(rename="networkID")]
#[serde(deserialize_with="uint::validate_non_zero")]
pub network_id: Uint,
/// Chain id.
#[serde(rename="chainID")]
Expand Down Expand Up @@ -209,20 +208,4 @@ mod tests {

let _deserialized: Params = serde_json::from_str(s).unwrap();
}

#[test]
#[should_panic(expected = "a non-zero value")]
fn test_non_zero_network_id() {
let s = r#"{
"maximumExtraDataSize": "0x20",
"networkID" : "0x0",
"subprotocolName" : "exp",
"minGasLimit": "0x1388",
"accountStartNonce": "0x01",
"gasLimitBoundDivisor": "0x20",
"maxCodeSize": "0x1000"
}"#;

let _deserialized: Params = serde_json::from_str(s).unwrap();
}
}