This repository was archived by the owner on Nov 6, 2020. It is now read-only.
EIP 191#9701
Merged
Merged
Conversation
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
sorpaas
added
A0-pleasereview 🤓
5chdn
requested review from
andresilva and
tomusdrw
and removed request for
tomusdrw
Contributor
|
please rebase on master @seunlanlege please review this well |
Member
Author
|
actually this depends on #9631 |
Collaborator
|
Unreviewable in current state, we need to get #9631 merged first. |
Member
|
please rebase on master |
Contributor
|
#9631 is merged, please rebase |
Member
Author
|
done |
Contributor
|
does not compile |
Member
Author
|
rebase went wrong, fixed it now |
ordian
approved these changes
Nov 1, 2018
Member
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
looks good, but adding docs and tests never hurts :)
| use serde::de; | ||
| use v1::types::{H160, Bytes}; | ||
|
|
||
| pub enum EIP191Version { |
Member
There was a problem hiding this comment.
Please document all public types/fields/functions
Collaborator
There was a problem hiding this comment.
missing docs for variants
ordian
added
A6-mustntgrumble 💦
Contributor
|
Can you please add the function to the jsonrpc repo just like with eip712? |
…dded tests for sign191
ordian
added
A0-pleasereview 🤓
tomusdrw
approved these changes
Nov 13, 2018
Collaborator
tomusdrw
left a comment
tomusdrw
left a comment
There was a problem hiding this comment.
Looks good! What standard this method corresponds to?
It seems that here: https://github.com/ethereum/go-ethereum/pull/17789/files we have a different approach (it uses stringy content-type instead of versions as hex).
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| write!( | ||
| f, | ||
| "sign 0x{} with {}", |
Collaborator
There was a problem hiding this comment.
Should we change the previous implementation to distinguish between eip191 and this?
| use serde::de; | ||
| use v1::types::{H160, Bytes}; | ||
|
|
||
| pub enum EIP191Version { |
Collaborator
There was a problem hiding this comment.
missing docs for variants
seunlanlege
added a commit
that referenced
this pull request
Nov 14, 2018
* added sign_191 rpc method * fixed hash_structured_data return type * added ConfirmationPayload::SignMessage for non-prefixed signatures, added tests for sign191 * renamed WithValidator -> PresignedTransaction * rename applicationData to data in test * adds docs for EIP191Version, renamed SignRequest to EIP191SignRequest
This was referenced Nov 14, 2018
Merged
Merged
Tbaut
added
A8-looksgood 🦄
Contributor
|
Is |
Member
Author
In clef, it's currently implemented as |
Tbaut
added a commit
that referenced
this pull request
Nov 14, 2018
* Bump beta to version 2.2.1 * fix: Intermittent failing CI due to addr in use (#9885) Allow OS to set port at runtime * Use Weak reference in PubSubClient (#9886) * Fix json tracer overflow (#9873) * Fix json tracer overflow * Replace trace_executed with a direct trace push * Remove unused variable * Add test for 5a51 * Remove duplicate json! * Fix docker script (#9854) * Dockerfile: change source path of the newly added check_sync.sh (#9869) * Allow to seal work on latest block (#9876) * Allow to seal work on latest block. * Test from @todr to check sealing conditions. * gitlab-ci: make android release build succeed (#9743) * use docker cargo config file for android builds * make android build succeed * ethcore: use Machine::verify_transaction on parent block (#9900) * ethcore: use Machine::verify_transaction on parent block also fixes off-by-one activation of transaction permission contract * ethcore: clarify call to verify_transaction * foundation: #6692865, ropsten: #4417537, kovan: #9363457 * Remove rust-toolchain file (#9906) * EIP-712 implementation (#9631) * EIP-712 impl * added more tests * removed size parsing unwrap * corrected TYPE_REGEX to disallow zero sized fixed length arrays, replaced LinkedHashSet with IndexSet, added API spec to docs, fixed Type::Byte encoding branch * use Option<u64> instead of u64 for Type::Array::Length * replace `.iter()` with `.values()` Co-Authored-By: seunlanlege <seunlanlege@gmail.com> * tabify eip712.rs * use proper comments for docs * Cargo.lock: revert unrelated changes * tabify encode.rs * EIP 191 (#9701) * added sign_191 rpc method * fixed hash_structured_data return type * added ConfirmationPayload::SignMessage for non-prefixed signatures, added tests for sign191 * renamed WithValidator -> PresignedTransaction * rename applicationData to data in test * adds docs for EIP191Version, renamed SignRequest to EIP191SignRequest * light-fetch: Differentiate between out-of-gas/manual throw and use required gas from response on failure (#9824) * fix start_gas, handle OOG exceptions & NotEnoughGas * Change START_GAS: 50_000 -> 60_000 * When the `OutOfGas exception` is received then try to double the gas until it succeeds or block gas limit is reached * When `NotEnoughBasGas error` is received then use the required gas provided in the response * fix(light-fetch): ensure block_gas_limit is tried Try the `block_gas_limit` before regard the execution as an error * Update rpc/src/v1/helpers/light_fetch.rs Co-Authored-By: niklasad1 <niklasadolfsson1@gmail.com> * simplify cargo audit * Use block header for building finality (#9914) * ci: nuke the gitlab caches (#9855)
5chdn
added
the
B7-releasenotes 📜
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implemented EIP-191 signing (
personal_sign191)