Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

rpc-docs should push the branch#9611

Merged
debris merged 1 commit into
betafrom
beta-rpc-doc-push-to-head
Sep 21, 2018
Merged

rpc-docs should push the branch#9611
debris merged 1 commit into
betafrom
beta-rpc-doc-push-to-head

Conversation

@gabreal
Copy link
Copy Markdown
Contributor

@gabreal gabreal commented Sep 20, 2018

No description provided.

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Sep 20, 2018

It looks like @gabreal signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. M1-ci 🙉 Continuous integration. labels Sep 20, 2018
debris
debris suggested changes Sep 21, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@debris debris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when is this function called? Is it called only after building new release?

what is ${CI_COMMIT_REF_NAME}? if it's always the same, push will fail because of merge conflicts. How do we access the latest version of the docs?

I'm marking as request changes, only because I'd like to get answers before it is merged :)

@ordian
Copy link
Copy Markdown
Member

ordian commented Sep 21, 2018

@debris
Currently we push only tags to wiki, see https://github.com/paritytech/wiki/commits/v2.0.5.
Pushing branches along with tags is no worse in terms of conflicts.

@5chdn 5chdn added this to the Patch milestone Sep 21, 2018
@5chdn
Copy link
Copy Markdown
Contributor

5chdn commented Sep 21, 2018

CI_COMMIT_REF_NAME is always the tag and tags are unique, so in the rare case someone force-tags this, it's ok if this pipeline fails. @debris

@debris debris merged commit 8e347b2 into beta Sep 21, 2018
@debris debris deleted the beta-rpc-doc-push-to-head branch September 21, 2018 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@5chdn 5chdn Awaiting requested review from 5chdn

3 more reviewers

@General-Beck General-Beck General-Beck approved these changes

@debris debris debris approved these changes

@ordian ordian ordian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood 🦄 Pull request is reviewed well. M1-ci 🙉 Continuous integration.

Projects

None yet

Milestone

Patch

Development

Successfully merging this pull request may close these issues.

6 participants

@gabreal @parity-cla-bot @ordian @5chdn @General-Beck @debris