This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Beta backports to 2.0.4#9452
Merged
Merged
Conversation
5chdn
added
A3-inprogress ⏳
… unify error handeling for light and full client (#9383) * Provide the actual `account` for eth_coinbase The previous implementation always provided the `zero address` on `eth_coinbase` RPC. Now, instead the actual address is returned on success or an error when no account(s) is found! * full client `eth_coinbase` return err In the full-client return an error when no account is found instead of returning the `zero address` * Remove needless blocks on single import * Remove needless `static` lifetime on const * Fix `rpc_eth_author` test
5chdn
added
A0-pleasereview 🤓
* Only check warp syncing for eth_getWorks * Use SyncStatus::is_snapshot_syncing
* Close Blooms DB files before DB restoration * PR Grumbles I * PR Grumble * Grumble
sorpaas
approved these changes
Sep 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calculate gas_used of the transaction trace correctly, (calculate gas_used of the transaction trace correctly, #9194)eth_coinbaseRPC ([light/jsonrpc] Provide the actual account foreth_coinbaseRPC and unify error handeling for light and full client #9383)