Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Update log -> 0.4, env_logger -> 0.5.#9294

Merged
andresilva merged 1 commit into
openethereum:masterfrom
poanetwork:c0gent-log
Aug 9, 2018
Merged

Update log -> 0.4, env_logger -> 0.5.#9294
andresilva merged 1 commit into
openethereum:masterfrom
poanetwork:c0gent-log

Conversation

@c0gent
Copy link
Copy Markdown
Contributor

@c0gent c0gent commented Aug 6, 2018

  • Rename a few types & methods.

  • Change (Log)Builder::format (closure) arg.

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Aug 6, 2018

It looks like @c0gent signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@c0gent c0gent force-pushed the c0gent-log branch 2 times, most recently from 1569cef to 02048eb Compare August 6, 2018 16:03
@c0gent
Update log -> 0.4, env_logger -> 0.5.
237bf2d 
* Rename a few types & methods.
* Change `(Log)Builder::format` (closure) arg.
@debris debris added the A8-looksgood 🦄 Pull request is reviewed well. label Aug 7, 2018
@niklasad1
Copy link
Copy Markdown
Collaborator

niklasad1 commented Aug 7, 2018

Hey @c0gent

Thanks for your PR!

Do you know if log v0.4 is compatible with log v0.3? Because a few crates still depend on log v0.3 and I want to make sure the logs still works for these!

For example hyper-rustls depends on log 0.3 and last time I checked it was not trivial to bump that crate because we use our own fork of ring which ended up in conflicting versions!

@c0gent
Copy link
Copy Markdown
Contributor Author

c0gent commented Aug 7, 2018 •
edited
Loading

According to the CHANGELOG, the only real incompatibility comes when consuming a 0.4-using crate from a 0.3-using one. In that case the module and file name information is lost. My understanding is (and in my limited testing) the reverse setup (as is the case here) works fine.

I will look more closely into the hyper tls crate we're using to make sure.

@c0gent
Copy link
Copy Markdown
Contributor Author

c0gent commented Aug 7, 2018

The latest version of hyper-rustls (0.13) is on log 0.4 (in its rustls dep.). The older version currently in use (0.11), currently uses log 3.9. Indeed, all log versions in use within Parity are at least 3.9 (according to Cargo.lock).

andresilva
andresilva approved these changes Aug 9, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andresilva
Copy link
Copy Markdown
Contributor

andresilva commented Aug 9, 2018

Thanks 👍

@andresilva andresilva merged commit e590874 into openethereum:master Aug 9, 2018
ordian added a commit to ordian/parity that referenced this pull request Aug 10, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
cfd6152 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  Allow setting the panic hook with parity-clib (openethereum#9292)
  Prevent blockchain & miner racing when accessing pending block. (openethereum#9310)
  Docker alpine: use multi-stage concept (openethereum#9269)
  Update `log` -> 0.4, `env_logger` -> 0.5. (openethereum#9294)
  Update tobalaba.json (openethereum#9313)
  Allow tx pool to be Send (openethereum#9315)
  Fix codecov.io badge in README (openethereum#9327)
  Move ethereum-specific H256FastMap type to own crate (openethereum#9307)
  ethcore sync decodes rlp less often (openethereum#9264)
@ascjones ascjones mentioned this pull request Aug 14, 2018
Merged
@5chdn 5chdn added this to the 2.1 milestone Aug 21, 2018
@5chdn 5chdn added M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies. labels Aug 21, 2018
@c0gent c0gent mentioned this pull request Aug 27, 2018
Open
43 tasks
@c0gent c0gent deleted the c0gent-log branch September 1, 2018 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@dvdplm dvdplm dvdplm approved these changes

@andresilva andresilva andresilva approved these changes

@debris debris debris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies.

Projects

None yet

Milestone

2.1 Whatever

Development

Successfully merging this pull request may close these issues.

7 participants

@c0gent @parity-cla-bot @niklasad1 @andresilva @dvdplm @debris @5chdn