Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Fix loop start value#9285

Merged
andresilva merged 1 commit into
openethereum:masterfrom
Jongsic:mistake
Aug 6, 2018
Merged

Fix loop start value#9285
andresilva merged 1 commit into
openethereum:masterfrom
Jongsic:mistake

Conversation

@Jongsic
Copy link
Copy Markdown
Contributor

@Jongsic Jongsic commented Aug 6, 2018

Fix loop start value of to_hash I think this is very little mistake.

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Aug 6, 2018

It looks like @Jongsic hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@Jongsic
Copy link
Copy Markdown
Contributor Author

Jongsic commented Aug 6, 2018

[clabot:check]

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Aug 6, 2018

It looks like @Jongsic signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

sorpaas
sorpaas approved these changes Aug 6, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This didn't trigger any test failure only because all our current usages are for from_hash == to_hash.

andresilva
andresilva approved these changes Aug 6, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch!

@andresilva andresilva merged commit 3f2fd61 into openethereum:master Aug 6, 2018
@andresilva
Copy link
Copy Markdown
Contributor

andresilva commented Aug 6, 2018

We should probably add some tests for this so we don't regress in the future. @Jongsic feel free to submit another PR if you want to add any tests for this. 🙂👍

@andresilva andresilva mentioned this pull request Aug 6, 2018
Merged
ordian added a commit to ordian/parity that referenced this pull request Aug 10, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
00aea86 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  ethcore: add transition flag for transaction permission contract (openethereum#9275)
  Remove all dapp permissions related settings (openethereum#9120)
  Improve return data truncate logic (openethereum#9254)
  Update wasm-tests hash (openethereum#9295)
  Implement KIP4: create2 for wasm (openethereum#9277)
  Fix loop start value (openethereum#9285)
  Avoid using $HOME if not necessary (openethereum#9273)
  Fix path to parity.h (openethereum#9274)
@5chdn 5chdn added this to the 2.1 milestone Aug 21, 2018
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. labels Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@andresilva andresilva andresilva approved these changes

@sorpaas sorpaas sorpaas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.

Projects

None yet

Milestone

2.1 Whatever

Development

Successfully merging this pull request may close these issues.

5 participants

@Jongsic @parity-cla-bot @andresilva @sorpaas @5chdn