This repository was archived by the owner on Nov 6, 2020. It is now read-only.
deserialize block only once during verification#9161
Merged
Conversation
debris
added
A0-pleasereview 🤓
sorpaas
added
A8-looksgood 🦄
ordian
approved these changes
Jul 25, 2018
Member
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
Can't say I fully understand the implications, but it LGTM.
| let t = engine.verify_transaction_unordered(t, &header)?; | ||
| if let Some(max_nonce) = nonce_cap { | ||
| if t.nonce >= max_nonce { | ||
| return Err(BlockError::TooManyTransactions(t.sender()).into()); |
Member
There was a problem hiding this comment.
Any reasons why we have return Err(....into()) in some places and bail!(...) in other ones apart from historical?
Contributor
There was a problem hiding this comment.
I would say it's for historical reasons and lack of style enforcement (I always forget to use bail!). At some point we should migrate from error_chain to failure and we can do a cleanup to have more consistent error handling.
andresilva
approved these changes
Jul 25, 2018
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
LGTM. Just a minor formatting nit.
| let t = engine.verify_transaction_unordered(t, &header)?; | ||
| if let Some(max_nonce) = nonce_cap { | ||
| if t.nonce >= max_nonce { | ||
| return Err(BlockError::TooManyTransactions(t.sender()).into()); |
Contributor
There was a problem hiding this comment.
I would say it's for historical reasons and lack of style enforcement (I always forget to use bail!). At some point we should migrate from error_chain to failure and we can do a cleanup to have more consistent error handling.
| })); | ||
| } | ||
| let expected_uncles = keccak(block_rlp.at(2)?.as_raw()); | ||
| if &expected_uncles != block.header.uncles_hash(){ |
Contributor
There was a problem hiding this comment.
block.header.uncles_hash(){ that poor { can't breathe. 😛
Merged
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jul 31, 2018
* 'master' of https://github.com/paritytech/parity: removed client error (openethereum#9253) Implement EIP-1052 (EXTCODEHASH) and fix several issues in state account cache (openethereum#9234) Improve Tracer documentation (openethereum#9237) Update Dockerfile (openethereum#9242) block cleanup (openethereum#9117) Increase the number of sessions. (openethereum#9203) add changelog for 1.11.8 stable and 2.0.1 beta (openethereum#9230) fix typo (openethereum#9232) Fix potential as_usize overflow when casting from U256 in miner (openethereum#9221) Allow old blocks from peers with lower difficulty (openethereum#9226) Removes duplicate libudev-dev from Dockerfile (openethereum#9220) snap: remove ssl dependencies from snapcraft definition (openethereum#9222) remove ssl from dockerfiles, closes openethereum#8880 (openethereum#9195) Insert PROOF messages for some cases in blockchain (openethereum#9141) [Chain] Add more bootnodes (openethereum#9174) ethcore: update bn version (openethereum#9217) deserialize block only once during verification (openethereum#9161) Simple build instruction fix (openethereum#9215) Added --tx-queue-no-early-reject flag to disable early tx queue rejects (openethereum#9143)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first pull request that tries to limit number of times the block is being deserialized.
before:
now: