This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Conversation
sorpaas
added
A0-pleasereview 🤓
EIP-168 is not enabled by default
sorpaas
force-pushed
the
sp-bugfix-hard-fork
branch
from
d3b86cf to
13d5000
Compare
Contributor
|
does this require a backport? |
Collaborator
Author
|
Given this is a bugfix for bugfix hard fork and the change is simple, backporting it would be fine. :) |
This was referenced Jul 17, 2018
andresilva
approved these changes
Jul 17, 2018
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
I had a look at all the EIPs that you removed from the "bugfix" list and it lgtm, but I'd appreciate that someone with more knowledge about them also take a look.
niklasad1
reviewed
Jul 18, 2018
| self.eip211_transition != 0 && self.eip214_transition != 0 && | ||
| self.validate_chain_id_transition != 0 && self.dust_protection_transition != 0 | ||
| /// Return Some if the current parameters contain a bugfix hard fork not on block 0. | ||
| pub fn nonzero_bugfix_hard_fork(&self) -> Option<&'static str> { |
Collaborator
There was a problem hiding this comment.
static lifetime annotation is not required anymore so Option<&str> should be enough!
debris
approved these changes
Jul 19, 2018
Collaborator
debris
left a comment
debris
left a comment
There was a problem hiding this comment.
I also had to double-check everything, but it LGTM
debris
added
A8-looksgood 🦄
5chdn
pushed a commit
that referenced
this pull request
Jul 24, 2018
* Fix bugfix hard fork logic * Remove dustProtectionTransition from bugfix category EIP-168 is not enabled by default * Remove unnecessary 'static
5chdn
pushed a commit
that referenced
this pull request
Jul 24, 2018
* Fix bugfix hard fork logic * Remove dustProtectionTransition from bugfix category EIP-168 is not enabled by default * Remove unnecessary 'static
5chdn
added a commit
that referenced
this pull request
Jul 25, 2018
* parity-version: bump stable to 1.11.8 * ci: update version strings for snaps * Be more graceful on Aura difficulty validation (#9164) * Be more graceful on Aura difficulty validation * test: rejects_step_backwards * test: proposer_switching * test: rejects_future_block * test: reports_skipped * test: verify_empty_seal_steps * parity: fix UserDefaults json parser (#9189) * parity: fix UserDefaults json parser * parity: use serde_derive for UserDefaults * parity: support deserialization of old UserDefault json format * parity: make UserDefaults serde backwards compatible * parity: tabify indentation in UserDefaults * Fix bugfix hard fork logic (#9138) * Fix bugfix hard fork logic * Remove dustProtectionTransition from bugfix category EIP-168 is not enabled by default * Remove unnecessary 'static * Disable per-sender limit for local transactions. (#9148) * Disable per-sender limit for local transactions. * Add a missing new line. * rpc: fix is_major_importing sync state condition (#9112) * rpc: fix is_major_importing sync state condition * rpc: fix informant printout when waiting for peers * fix verification in ethcore-sync collect_blocks (#9135) * docker: update hub dockerfile (#9173) * update Dockerfile for hub update to Ubuntu Xenial 16.04 fix cmake version * docker: fix tab indentation in hub dockerfile * ethcore: update to parity-wasm 0.31 * rpc: fix broken merge
5chdn
added a commit
that referenced
this pull request
Jul 26, 2018
* parity-version: bump beta to 2.0.1 * ci: update version strings for snaps * Be more graceful on Aura difficulty validation (#9164) * Be more graceful on Aura difficulty validation * test: rejects_step_backwards * test: proposer_switching * test: rejects_future_block * test: reports_skipped * test: verify_empty_seal_steps * Remove node-health (#9119) * Remove node-health * Remove ntp_servers * Add --ntp-servers as legacy instead of removing it * Add --ntp-servers to deprecated args * Remove unused stuff * Remove _legacy_ntp_servers * parity: fix UserDefaults json parser (#9189) * parity: fix UserDefaults json parser * parity: use serde_derive for UserDefaults * parity: support deserialization of old UserDefault json format * parity: make UserDefaults serde backwards compatible * parity: tabify indentation in UserDefaults * Fix bugfix hard fork logic (#9138) * Fix bugfix hard fork logic * Remove dustProtectionTransition from bugfix category EIP-168 is not enabled by default * Remove unnecessary 'static * Disable per-sender limit for local transactions. (#9148) * Disable per-sender limit for local transactions. * Add a missing new line. * rpc: fix is_major_importing sync state condition (#9112) * rpc: fix is_major_importing sync state condition * rpc: fix informant printout when waiting for peers * fix verification in ethcore-sync collect_blocks (#9135) * docker: update hub dockerfile (#9173) * update Dockerfile for hub update to Ubuntu Xenial 16.04 fix cmake version * docker: fix tab indentation in hub dockerfile * rpc: fix broken merge * rcp: remove node_health leftover from merge * rpc: remove dapps leftover from merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bugfix hard fork is something that should always be on by default. When checking, it should use
||instead of&&. In addition, EIP86, EIP98, etc do not belong to this category.This PR also changes the function to return a string instead, so it can tell the operator what needs to be changed in the chain spec config.